]> dgit.raspbian.org Git - gnome-shell.git/commit
st: Drop explicit Clutter grab in StButton
authorCarlos Garnacho <carlosg@gnome.org>
Wed, 30 Aug 2023 08:14:16 +0000 (10:14 +0200)
committerMarge Bot <marge-bot@gnome.org>
Thu, 31 Aug 2023 14:17:16 +0000 (14:17 +0000)
commit52182e6493d047dca4a95b4ecda5856a7c86d4f1
treeeaf65d1f1460c7f670ccfbc9da9ddc3c1efc7f36
parent3a393738ea07c47f5571b4cfc317351306a6212a
st: Drop explicit Clutter grab in StButton

Nowadays, Clutter knows what an implicit grab is, which gives
us already the feel that we are after with buttons (e.g. press
and drag on the button will not enter other actors meanwhile).

ClutterGrab was only added to provide that feel meanwhile, and
it's also slightly more intense (e.g. altering keyboard focus,
or triggering leave events on all parents of the button) which
may trigger side effects.

An example is the IBus candidates popup, where the pagination
buttons may indirectly trigger dismissing of the entire popup
when interacted, by stealing the keyboard focus to the
client/actor doing IM.

Related: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2497
Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/2244
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2924>
src/st/st-button.c